-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure column names are valid when writing benchmark query results to file #1247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andy Grove <andygrove@nvidia.com>
andygrove
changed the title
Ensure column names are valid when writing benchmark query results to file
WIP: Ensure column names are valid when writing benchmark query results to file
Dec 2, 2020
Is this an issue for CPU plans as well? Or just the GPU plans? From the exceptions in the issue it does look like Spark is complaining about this. |
Yes, this happens on CPU as well:
|
andygrove
changed the title
WIP: Ensure column names are valid when writing benchmark query results to file
Ensure column names are valid when writing benchmark query results to file
Dec 2, 2020
abellina
approved these changes
Dec 2, 2020
build |
1 similar comment
build |
This PR needs to be upmerged to include the latest changes in branch-0.3 |
build |
tests timed out - build |
build |
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
… file (NVIDIA#1247) * Enforce unique column names when writing query output to file * preserve valid names Signed-off-by: Andy Grove <andygrove@nvidia.com>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
… file (NVIDIA#1247) * Enforce unique column names when writing query output to file * preserve valid names Signed-off-by: Andy Grove <andygrove@nvidia.com>
tgravescs
pushed a commit
to tgravescs/spark-rapids
that referenced
this pull request
Nov 30, 2023
…IDIA#1247) Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure column names are valid when writing benchmark query results to file.
This closes #1246