At BatchedTableCompressor.finish synchronize to allow for "right-size… #1248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…" copies to finish before it is potentially spilled Signed-off-by: Alessandro Bellina <abellina@nvidia.com>
jlowe
approved these changes
Dec 3, 2020
|
build |
1 similar comment
|
build |
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
…" copies to finish before it is potentially spilled (NVIDIA#1248) Signed-off-by: Alessandro Bellina <abellina@nvidia.com>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
…" copies to finish before it is potentially spilled (NVIDIA#1248) Signed-off-by: Alessandro Bellina <abellina@nvidia.com>
tgravescs
pushed a commit
to tgravescs/spark-rapids
that referenced
this pull request
Nov 30, 2023
* Back port spark-specific murmur32 hash code from cudf. * Run pre-commit to format files. We were behind a bit. * Update pre-commit config to 16.0.1 to match cudf. Re-ran formatting. * Change jni bindings to use the spark-rapids-jni implementation of murmur hash instead of the cudf version. Brought over cpp and java tests. * Documentation fix. * Fix cpp tests to actually call the spark_rapids_jni murmur hash. * First pass at xxhash64. cpp tests passing. * Improve cpp tests - null cases and more floating point edge cases. * Add Java tests. * Moved murmur32 hash implementaion from cudf to spark-rapids-jni Signed-off-by: db <dbaranec@nvidia.com> * PR review changes. * Fix copyright data in Hash.java * Enable 32 bit decimal hash test. * Implement xxhash64 on the gpu Signed-off-by: db <dbaranec@nvidia.com> * Add missing newlines. * PR review changes. * Remove default xxhash64 class constructor. Remove unused parameter (row index) from remaining constructor. * Fix issues with merge. * Rectify thirdparty/cudf issues. * Revert inadvertent change to pom.xml * PR review feedback changes. --------- Signed-off-by: db <dbaranec@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the P1 nature of #1245 for branch-0.3