Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and edit docs for standalone mode #1342

Merged
merged 2 commits into from
Dec 9, 2020

Conversation

sameerz
Copy link
Collaborator

@sameerz sameerz commented Dec 9, 2020

Signed-off-by: Sameer Raheja sraheja@nvidia.com

Fixed getting started on prem document for standalone mode to include spark.executor.resource.gpu.amount for the spark-shell example. Modified number of GPUs for the worker in the example to 1 instead of 4.

Signed-off-by: Sameer Raheja <sraheja@nvidia.com>
@sameerz sameerz added the documentation Improvements or additions to documentation label Dec 9, 2020
@sameerz sameerz added this to the Dec 7 - Dec 18 milestone Dec 9, 2020
@sameerz sameerz self-assigned this Dec 9, 2020
@sameerz
Copy link
Collaborator Author

sameerz commented Dec 9, 2020

build

revans2
revans2 previously approved these changes Dec 9, 2020
@@ -134,7 +134,7 @@ Now for each worker node:
- `cp $SPARK_HOME/conf/spark-env.sh.template $SPARK_HOME/conf/spark-env.sh`
- Edit `$SPARK_HOME/conf/spark-env.sh` and add any worker options. The example below sets the
number of GPUs per worker to 4 and points to the discovery script. Change this for your setup.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't match below now. we can leave this 4 or if you think its confusing change the text.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was unsure of whether to change that part of the example or not. It was a little confusing to me, but I think that was just me :-) I will change it back to 4.

Signed-off-by: Sameer Raheja <sraheja@nvidia.com>
@sameerz
Copy link
Collaborator Author

sameerz commented Dec 9, 2020

build

@jlowe jlowe merged commit 1e3181a into NVIDIA:branch-0.3 Dec 9, 2020
@sameerz sameerz deleted the branch-0.3-standalone-doc-fix branch February 4, 2021 20:04
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
* Fix and edit docs for standalone mode

Signed-off-by: Sameer Raheja <sraheja@nvidia.com>

* Revert the example back to four GPUs per worker

Signed-off-by: Sameer Raheja <sraheja@nvidia.com>
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
* Fix and edit docs for standalone mode

Signed-off-by: Sameer Raheja <sraheja@nvidia.com>

* Revert the example back to four GPUs per worker

Signed-off-by: Sameer Raheja <sraheja@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants