MetaUtils.getBatchFromMeta should return batches with GpuColumnVectorFromBuffer #1376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…FromBuffer Signed-off-by: Jason Lowe <jlowe@nvidia.com>
jlowe
added
bug
|
build |
revans2
approved these changes
Dec 11, 2020
abellina
approved these changes
Dec 11, 2020
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
…FromBuffer (NVIDIA#1376) Signed-off-by: Jason Lowe <jlowe@nvidia.com>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
…FromBuffer (NVIDIA#1376) Signed-off-by: Jason Lowe <jlowe@nvidia.com>
tgravescs
pushed a commit
to tgravescs/spark-rapids
that referenced
this pull request
Nov 30, 2023
…IDIA#1376) Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building a
ColumnarBatchfrom a device buffer and shuffle metadata,MetaUtilsis not returning a batch withGpuColumnVectorFromBufferinstances but rather normalGpuColumnVectorinstances. When these batches are seen by the subsequentGpuCoalesceBatchesnode in the query plan,GpuCoalesceBatchesmistakenly thinks the columns are not from a contiguous buffer and performs a redundant contiguous split on the batch.