Optimize mvn dependency download scripts #1416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NvTimLiu
requested review from
GaryShen2008,
jlowe,
revans2 and
tgravescs
as code owners
NvTimLiu
force-pushed
the
optimize-mvn-download
branch
from
5c64f98
to
c68d173
Compare
|
build |
pxLi
previously approved these changes
Dec 17, 2020
|
Looks good if both pre-merge test and integration tests can pass w/ the script change |
jlowe
changed the title
jlowe
previously approved these changes
Dec 17, 2020
revans2
previously approved these changes
Dec 17, 2020
|
fix merge conflicts |
|
build |
NvTimLiu
commented
Dec 18, 2020
|
build |
jlowe
approved these changes
Dec 18, 2020
jlowe
requested changes
Dec 18, 2020
jenkins/version-def.sh
Outdated
| @@ -29,9 +29,15 @@ IFS=$PRE_IFS | |||
| CUDF_VER=${CUDF_VER:-"0.18-SNAPSHOT"} | |||
| CUDA_CLASSIFIER=${CUDA_CLASSIFIER:-"cuda10-1"} | |||
| PROJECT_VER=${PROJECT_VER:-"0.4.0-SNAPSHOT"} | |||
| RROJECT_TEST_VER=${PROJECT_TEST_VER:-"0.4.0-SNAPSHOT"} | |||
There was a problem hiding this comment.
Just noticed this typo:
Suggested change
| RROJECT_TEST_VER=${PROJECT_TEST_VER:-"0.4.0-SNAPSHOT"} | |
| PROJECT_TEST_VER=${PROJECT_TEST_VER:-"0.4.0-SNAPSHOT"} |
There was a problem hiding this comment.
@jlowe Thanks a lot!
Move definition of the maven repo into 'version-def.sh', then by overwrite the repo URL it can download either SNAPSHOT cuDF/spark-rapids jars from the internal repo, for the nightly integration tests; or it can download the pre-release jars on the Sonatype repo, for the release verify integration tests. The default maven repo is internal one for the nightly SNAPSHOT integration tests. Signed-off-by: Tim Liu <timl@nvidia.com>
NvTimLiu
force-pushed
the
optimize-mvn-download
branch
from
125d6e8
to
1b267f5
Compare
|
build |
jlowe
approved these changes
Jan 4, 2021
There was a problem hiding this comment.
Looks good, thanks!
@NvTimLiu in the future, please avoid force-pushing to PRs that are being reviewed. It makes it difficult to see what has changed since the last time a reviewer looked at the PR and often review comments become disconnected from the code. It's better to merge up to the latest branch, and as a bonus Github won't dismiss prior approvals if the merge was clean after the approval.
Got it, thanks! |
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* Optimize mvn denpendency download scripts Move definition of the maven repo into 'version-def.sh', then by overwrite the repo URL it can download either SNAPSHOT cuDF/spark-rapids jars from the internal repo, for the nightly integration tests; or it can download the pre-release jars on the Sonatype repo, for the release verify integration tests. The default maven repo is internal one for the nightly SNAPSHOT integration tests. Signed-off-by: Tim Liu <timl@nvidia.com> * fix typo Signed-off-by: Tim Liu <timl@nvidia.com>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* Optimize mvn denpendency download scripts Move definition of the maven repo into 'version-def.sh', then by overwrite the repo URL it can download either SNAPSHOT cuDF/spark-rapids jars from the internal repo, for the nightly integration tests; or it can download the pre-release jars on the Sonatype repo, for the release verify integration tests. The default maven repo is internal one for the nightly SNAPSHOT integration tests. Signed-off-by: Tim Liu <timl@nvidia.com> * fix typo Signed-off-by: Tim Liu <timl@nvidia.com>
tgravescs
pushed a commit
to tgravescs/spark-rapids
that referenced
this pull request
Nov 30, 2023
* Add files and empty functions Signed-off-by: Nghia Truong <nghiat@nvidia.com> * Implementing histogram-to-percentile Signed-off-by: Nghia Truong <nghiat@nvidia.com> * Implement `percentile_from_histogram` Signed-off-by: Nghia Truong <nghiat@nvidia.com> * Add Java interface Signed-off-by: Nghia Truong <nghiat@nvidia.com> * Input `percentage` as GPU column Signed-off-by: Nghia Truong <nghiat@nvidia.com> * Wrap in list if needed Signed-off-by: Nghia Truong <nghiat@nvidia.com> * Implementing groupby percentile Signed-off-by: Nghia Truong <nghiat@nvidia.com> * Cleanup and docs Signed-off-by: Nghia Truong <nghiat@nvidia.com> * Fix null issue Signed-off-by: Nghia Truong <nghiat@nvidia.com> * Implement null check Signed-off-by: Nghia Truong <nghiat@nvidia.com> * Fix typo Signed-off-by: Nghia Truong <nghiat@nvidia.com> * Cleanup Signed-off-by: Nghia Truong <nghiat@nvidia.com> * Cleanup Signed-off-by: Nghia Truong <nghiat@nvidia.com> * Change back to use the less error-prone segmented sort Signed-off-by: Nghia Truong <nghiat@nvidia.com> * Fix all nulls cases Signed-off-by: Nghia Truong <nghiat@nvidia.com> * Debugging Signed-off-by: Nghia Truong <nghiat@nvidia.com> * Fix null handling Signed-off-by: Nghia Truong <nghiat@nvidia.com> * Fix empty input handling Signed-off-by: Nghia Truong <nghiat@nvidia.com> * Fix access indices Signed-off-by: Nghia Truong <nghiat@nvidia.com> * Fix accumulated counts computation Signed-off-by: Nghia Truong <nghiat@nvidia.com> * WIP Signed-off-by: Nghia Truong <nghiat@nvidia.com> * Implement input projection for values with frequencies Signed-off-by: Nghia Truong <nghiat@nvidia.com> * All tests passed!!! Signed-off-by: Nghia Truong <nghiat@nvidia.com> * Cleanup and docs Signed-off-by: Nghia Truong <nghiat@nvidia.com> * Rename files and class * Change docs * Rename function, rewrite docs, and cleanup * Rewrite comments * Handling zero frequency * Remove too detail comment * Update src/main/java/com/nvidia/spark/rapids/jni/Histogram.java * Update src/main/java/com/nvidia/spark/rapids/jni/Histogram.java * Change error messages --------- Signed-off-by: Nghia Truong <nghiat@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move definition of the maven repo into 'version-def.sh', then by overwrite the repo URL
it can download either
SNAPSHOTcuDF/spark-rapids jars from the internal repo, for the nightly integration tests;or it can download the
pre-releasejars on the Sonatype repo, for the release verify integration tests. The default maven repo is internal one for the nightly SNAPSHOT integration tests.