-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Join support for DecimalType #1475
Conversation
Signed-off-by: Niranjan Artal <nartal@nvidia.com>
Signed-off-by: Niranjan Artal <nartal@nvidia.com>
@@ -23,7 +23,9 @@ | |||
all_gen = [StringGen(), ByteGen(), ShortGen(), IntegerGen(), LongGen(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its better to use the all_gen
in data_gen.py
and add the stuff missing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I really hate all_gen
being in data_gen.py because it is not really generating everything (all). I let it through before so I didn't say anything when it was reused, but if you do use it I would want it to be renamed so it is clear what is in it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all_gen
in data_gen.py
is missing these 2 gens: null_gen, decimal_gen_neg_scale
.
Please let me know if below would be acceptable name if we want to rename it for better readability?
all_gen_minus_null_gen_and_decimal_gen_neg_scale
ORall_gen_excluding_null_gen_and_decimal_gen_neg_scale
(problem I see with this is we may have to rename it again if we add any other gen in the future which is not included in this variable).
Suggestions are welcome on variable name :) .
Or would you prefer to keep all_gen
local to the test files and remove it from data_gen.py
?(I can create follow on PR for that as it involves changing other files).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't think of a name suitable. @jlowe is better at naming things may be he has something
The right thing to do in my mind would be to add everything
in all_gen
and let tests create local versions of a list if they need something different. Considering it might break tests if you add everything in all_gen
lets create a follow-on for this as a lower priority task
@@ -23,7 +23,9 @@ | |||
all_gen = [StringGen(), ByteGen(), ShortGen(), IntegerGen(), LongGen(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I really hate all_gen
being in data_gen.py because it is not really generating everything (all). I let it through before so I didn't say anything when it was reused, but if you do use it I would want it to be renamed so it is clear what is in it.
build |
* DecimalType support for joins Signed-off-by: Niranjan Artal <nartal@nvidia.com> * update copyrights Signed-off-by: Niranjan Artal <nartal@nvidia.com>
* DecimalType support for joins Signed-off-by: Niranjan Artal <nartal@nvidia.com> * update copyrights Signed-off-by: Niranjan Artal <nartal@nvidia.com>
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
This fixes #1326 and #1325