DecimalType support for Aggregate Count #1476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turned it on and added test Signed-off-by: Raza Jafri <rjafri@nvidia.com>
jlowe
previously approved these changes
Jan 8, 2021
revans2
approved these changes
Jan 8, 2021
|
build |
revans2
requested changes
Jan 8, 2021
| @@ -418,3 +418,10 @@ def test_arithmetic_reductions(data_gen): | |||
| 'avg(a)'), | |||
| conf = _no_nans_float_conf) | |||
|
|
|||
| @ignore_order | |||
| @pytest.mark.parametrize('data_gen', all_gen, ids=idfn) | |||
| @pytest.mark.parametrize('count_func', [f.count, f.countDistinct], ids=idfn) | |||
There was a problem hiding this comment.
Using a function in here with idfn is producing different names each time the test runs and is causing the parallel runs of the tests to fail. If you drop the ids=idfn it fixes the problem
idfn causes a problem when passing a function as a parameter to the test Signed-off-by: Raza Jafri <rjafri@nvidia.com>
revans2
approved these changes
Jan 8, 2021
|
build |
revans2
approved these changes
Jan 8, 2021
6 tasks
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
tgravescs
pushed a commit
to tgravescs/spark-rapids
that referenced
this pull request
Nov 30, 2023
…IDIA#1476) Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turned on the Decimal Type for Count on and added test
Signed-off-by: Raza Jafri rjafri@nvidia.com
This fixes #1334