Rename Spark 3.1.0 shim to Spark 3.1.1 to match community #1488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Graves <tgraves@nvidia.com>
Signed-off-by: Thomas Graves <tgraves@nvidia.com>
tgravescs
requested review from
GaryShen2008,
jlowe,
NvTimLiu and
revans2
as code owners
|
build |
jlowe
approved these changes
Jan 11, 2021
revans2
approved these changes
Jan 11, 2021
|
@razajafri any reason the ParquetMaterializer wasn't in a shim specific package? if not we should file an issue and put it in one. It can still be in the spark package for example we have: spark311/src/main/scala/org/apache/spark/sql/rapids/shims/spark311/GpuColumnarToRowTransitionExec.scala |
|
When I created the file I added a |
|
yes please match the other files in the shim with shims.spark311 |
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* Rename spark310 to spark311 Signed-off-by: Thomas Graves <tgraves@nvidia.com> * Fix typoes Signed-off-by: Thomas Graves <tgraves@nvidia.com>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* Rename spark310 to spark311 Signed-off-by: Thomas Graves <tgraves@nvidia.com> * Fix typoes Signed-off-by: Thomas Graves <tgraves@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1487
Rename the shim to match the community versions. There won't be a 3.1.0 so no reason to keep that shim. I left the 3.1.0-SNAPSHOT as supported in the service provider list for now in case anyone was using those snapshots.