Switch CICD pipelines to Github #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1, Change ${gitlabBranch} to ${sha1} in Jenkinsfile.premerge,
because on Github, the env VAR of Jenkins reference branch is 'sha1'
2, Remove all the 'Gitlab' related functions
3, Point the integration pipeline name (spark/plugin_integration) to
the Github one(spark/rapids_integration-0.1-github).
NvTimLiu
changed the title
revans2
approved these changes
Jun 11, 2020
jlowe
reviewed
Jun 11, 2020
| @@ -75,16 +75,14 @@ pipeline { | |||
| always { | |||
| script { | |||
| if (currentBuild.currentResult == "SUCCESS") { | |||
| build(job: 'spark/plugin_integration', | |||
| build(job: 'spark/rapids_integration-0.1-github', | |||
| propagate: false, | |||
| parameters: [string(name: 'REF', value: 'branch-0.1'), | |||
| string(name: 'CUDF_VER', value: '0.14-SNAPSHOT'), | |||
There was a problem hiding this comment.
Shouldn't this be 0.14 instead of 0.14-SNAPSHOT?
There was a problem hiding this comment.
Oh yes, it should be 0.14.
I'll make a change to fix it.
There was a problem hiding this comment.
Bobby Evans had changed it, that's great!
calvinatnvidia
approved these changes
Jun 11, 2020
razajafri
approved these changes
Jun 11, 2020
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
1, Change ${gitlabBranch} to ${sha1} in Jenkinsfile.premerge,
because on Github, the env VAR of Jenkins reference branch is 'sha1'
2, Remove all the 'Gitlab' related functions
3, Point the integration pipeline name (spark/plugin_integration) to
the Github one(spark/rapids_integration-0.1-github).
Co-authored-by: Tim Liu <timl@nvidia.com>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
1, Change ${gitlabBranch} to ${sha1} in Jenkinsfile.premerge,
because on Github, the env VAR of Jenkins reference branch is 'sha1'
2, Remove all the 'Gitlab' related functions
3, Point the integration pipeline name (spark/plugin_integration) to
the Github one(spark/rapids_integration-0.1-github).
Co-authored-by: Tim Liu <timl@nvidia.com>
tgravescs
pushed a commit
to tgravescs/spark-rapids
that referenced
this pull request
Nov 30, 2023
Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1, Change ${gitlabBranch} to ${sha1} in Jenkinsfile.premerge, because on Github, the env VAR of Jenkins reference branch is 'sha1'.
Remove all the 'Gitlab' related functions.
Point the integration pipeline name (spark/plugin_integration) to the Github one (spark/rapids_integration-0.1-github).
2, Only update Jenkins scripts, no source change. No unit tests needed. Ngcc pipelines against forked Github PASS on pre-merge, nightly, and integration.
3, No Github issue related to the PR
4, CICD will work, after Ngcc pipelines updated.