Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support casting from decimal to decimal #1532

Merged
merged 3 commits into from
Jan 19, 2021

Conversation

sperlingxx
Copy link
Collaborator

Current pull request is created to address the remaining part of #1330, casting from decimal to another decimal type.

Signed-off-by: sperlingxx lovedreamf@gmail.com

Signed-off-by: sperlingxx <lovedreamf@gmail.com>
@sperlingxx
Copy link
Collaborator Author

build

@sperlingxx
Copy link
Collaborator Author

build

revans2
revans2 previously approved these changes Jan 15, 2021
Copy link
Collaborator

@revans2 revans2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code and tests look great. Just a minor nit on some extra comments I would like to see, but they are not critical.

@sameerz sameerz added the feature request New feature or request label Jan 17, 2021
@sperlingxx
Copy link
Collaborator Author

build

@revans2 revans2 merged commit bdcea12 into NVIDIA:branch-0.4 Jan 19, 2021
@revans2 revans2 mentioned this pull request Jan 19, 2021
27 tasks
@sperlingxx sperlingxx deleted the cast_dec_to_dec branch January 20, 2021 03:30
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
Signed-off-by: sperlingxx <lovedreamf@gmail.com>
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
Signed-off-by: sperlingxx <lovedreamf@gmail.com>
tgravescs pushed a commit to tgravescs/spark-rapids that referenced this pull request Nov 30, 2023
…IDIA#1532)

Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants