Support comparing ORC data #1545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Allen Xu <allxu@nvidia.com>
gerashegalov
previously approved these changes
Jan 20, 2021
Comment on lines
525
to
529
| path: String => spark.read.csv(path) | ||
| case "parquet" => | ||
| path: String => spark.read.parquet(path) | ||
| case "orc" => | ||
| path: String => spark.read.orc(path) |
There was a problem hiding this comment.
nit: this block L523-L530 can be a one-liner:
val readPathAction = (path: String) => spark.read.format(inputFormat).load(path)| @@ -53,6 +53,8 @@ object CompareResults { | |||
| (spark.read.csv(conf.input1()), spark.read.csv(conf.input2())) | |||
There was a problem hiding this comment.
Similarly lines https://github.com/NVIDIA/spark-rapids/pull/1545/files#diff-bc99ae208fb44d4abcf91b6e5b44515fbebeb90367c5f9eb1719e28226d22bf9R51-R68
can be
val format = spark.read.format(conf.inputFormat())
BenchUtils.compareResults(
format.load(conf.input1()),
format.load(conf.input2()),
conf.inputFormat(),
conf.ignoreOrdering(),
conf.useIterator(),
conf.maxErrors(),
conf.epsilon())
}
jlowe
requested changes
Jan 20, 2021
integration_tests/src/main/scala/com/nvidia/spark/rapids/tests/common/BenchUtils.scala
Show resolved
Hide resolved
integration_tests/src/main/scala/com/nvidia/spark/rapids/tests/common/CompareResults.scala
Show resolved
Hide resolved
Signed-off-by: Allen Xu <allxu@nvidia.com>
jlowe
previously approved these changes
Jan 21, 2021
|
build |
|
build |
jlowe
approved these changes
Jan 22, 2021
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* Support comparing ORC data Signed-off-by: Allen Xu <allxu@nvidia.com> * clean code * Add 2021 copyright Signed-off-by: Allen Xu <allxu@nvidia.com> * fix bug Co-authored-by: Allen Xu <allxu@nvidia.com>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* Support comparing ORC data Signed-off-by: Allen Xu <allxu@nvidia.com> * clean code * Add 2021 copyright Signed-off-by: Allen Xu <allxu@nvidia.com> * fix bug Co-authored-by: Allen Xu <allxu@nvidia.com>
tgravescs
pushed a commit
to tgravescs/spark-rapids
that referenced
this pull request
Nov 30, 2023
…IDIA#1545) Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Allen Xu allxu@nvidia.com
This is to resolve #1544