Cleanup shutdown logging for UCX shuffle #1546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@abellina could you elaborate more on what's being fixed here in the PR description? |
jlowe
reviewed
Jan 19, 2021
shuffle-plugin/src/main/scala/com/nvidia/spark/rapids/shuffle/ucx/UCX.scala
Outdated
Show resolved
Hide resolved
|
Would be good to update the PR headline as it's used as-is in the changelog. As it is now, users aren't going to know what it's talking about. |
abellina
changed the title
|
@jlowe let me know if this looks ok, I'll rebase it if so (and at least sign off the last commit, or squash). It looks like I confused the sign-off bot. |
jlowe
changed the title
jlowe
previously approved these changes
Jan 19, 2021
Signed-off-by: Alessandro Bellina <abellina@nvidia.com>
abellina
force-pushed
the
shuffle/init_close_cleanup
branch
from
b84e65a
to
1ca3b13
Compare
|
build |
1 similar comment
|
build |
shuffle-plugin/src/main/scala/com/nvidia/spark/rapids/shuffle/ucx/UCX.scala
Outdated
Show resolved
Hide resolved
|
build |
1 similar comment
|
build |
Signed-off-by: Alessandro Bellina <abellina@nvidia.com>
|
build |
|
@gerashegalov let me know if this looks OK to you. Thanks! |
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* Cleanup shutdown logging for UCX shuffle Signed-off-by: Alessandro Bellina <abellina@nvidia.com> * Address code review comments Signed-off-by: Alessandro Bellina <abellina@nvidia.com>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* Cleanup shutdown logging for UCX shuffle Signed-off-by: Alessandro Bellina <abellina@nvidia.com> * Address code review comments Signed-off-by: Alessandro Bellina <abellina@nvidia.com>
tgravescs
pushed a commit
to tgravescs/spark-rapids
that referenced
this pull request
Nov 30, 2023
…IDIA#1546) Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we clean up the logging in UCX scala such that we don't log a backtrace in the benign case that the management socket, which is constantly in
accept(), is closed due to a normal tear down.Java will throw a
SocketExceptionin this case, to unblock theaccept()call, and the application must distinguish this exception from other potential exceptions during the call.This PR also cleans up code around an extra lock we had, and makes the
initializedvolatile.Signed-off-by: Alessandro Bellina abellina@nvidia.com
Closes #1155