RAPIDS-accelerated Hive UDFs support all types #1551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
|
build |
revans2
reviewed
Jan 19, 2021
sql-plugin/src/main/scala/org/apache/spark/sql/hive/rapids/GpuHiveOverrides.scala
Show resolved
Hide resolved
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
|
build |
1 similar comment
|
build |
|
LGTM |
revans2
approved these changes
Jan 20, 2021
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* RAPIDS-accelerated Hive UDFs support all types Signed-off-by: Jason Lowe <jlowe@nvidia.com> * Remove UDT as a supported type for Hive UDFs Signed-off-by: Jason Lowe <jlowe@nvidia.com>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* RAPIDS-accelerated Hive UDFs support all types Signed-off-by: Jason Lowe <jlowe@nvidia.com> * Remove UDT as a supported type for Hive UDFs Signed-off-by: Jason Lowe <jlowe@nvidia.com>
tgravescs
pushed a commit
to tgravescs/spark-rapids
that referenced
this pull request
Nov 30, 2023
…IDIA#1551) Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the type-checks for RAPIDS-accelerated Hive UDFs state that they cannot support some nested types such as array-of-structs, but this isn't the case. From the plugin perspective, the input and output types are not examined but passed as-is into and out of the user-provided UDF. It is up to the user's code to support the type or not, so the plugin should not preclude support of these types as they can be represented in a cudf
ColumnVector.