Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch 0.4 doc cleanup #1570

Merged
merged 3 commits into from
Jan 22, 2021
Merged

Conversation

sameerz
Copy link
Collaborator

@sameerz sameerz commented Jan 22, 2021

Formatting changes: limiting line length, converting DOS to unix file format, and added a newline in TypeChecks.scala and rebuilt supported_ops.md.

Signed-off-by: Sameer Raheja <sraheja@nvidia.com>
Signed-off-by: Sameer Raheja <sraheja@nvidia.com>
@sameerz sameerz added the documentation Improvements or additions to documentation label Jan 22, 2021
@sameerz sameerz added this to the Jan 18 - Jan 29 milestone Jan 22, 2021
@sameerz sameerz self-assigned this Jan 22, 2021
@sameerz
Copy link
Collaborator Author

sameerz commented Jan 22, 2021

build

Copy link
Member

@jlowe jlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a lot of unnecessary change in this PR., Many lines with reasonable line lengths and normal line endings were reformatted in trivial ways that have no impact on the rendered output. Not something that needs to change for this PR, but it would be good to avoid for future doc updates.

If there's a formatting standard/tool everyone should be using then the contributing/dev docs should be updated.

docs/FAQ.md Outdated Show resolved Hide resolved
docs/compatibility.md Show resolved Hide resolved
Signed-off-by: Sameer Raheja <sraheja@nvidia.com>
@sameerz
Copy link
Collaborator Author

sameerz commented Jan 22, 2021

build

@sameerz sameerz merged commit a0edf73 into NVIDIA:branch-0.4 Jan 22, 2021
@sameerz sameerz deleted the branch-0.4-doc-cleanup branch February 4, 2021 20:04
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
* Formatting cleanup

Signed-off-by: Sameer Raheja <sraheja@nvidia.com>

* Further file formatting changes

Signed-off-by: Sameer Raheja <sraheja@nvidia.com>

* Change spark to Spark in the text

Signed-off-by: Sameer Raheja <sraheja@nvidia.com>
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
* Formatting cleanup

Signed-off-by: Sameer Raheja <sraheja@nvidia.com>

* Further file formatting changes

Signed-off-by: Sameer Raheja <sraheja@nvidia.com>

* Change spark to Spark in the text

Signed-off-by: Sameer Raheja <sraheja@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants