Support TakeOrderedAndProject #1579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
|
build |
jlowe
requested changes
Jan 26, 2021
sql-plugin/src/main/scala/com/nvidia/spark/rapids/SpillableColumnarBatch.scala
Show resolved
Hide resolved
sql-plugin/src/main/scala/com/nvidia/spark/rapids/SpillableColumnarBatch.scala
Show resolved
Hide resolved
sameerz
reviewed
Jan 26, 2021
docs/FAQ.md
Outdated
Comment on lines
43
to
45
| plan often has more metrics than the CPU versions do, and when we tried to combine all of these | ||
| operations into a single stage the metrics where confusing to understand what was happening. Instead | ||
| we split the single stage up into multiple smaller parts so the metrics are clearer. |
There was a problem hiding this comment.
Suggested change
| plan often has more metrics than the CPU versions do, and when we tried to combine all of these | |
| operations into a single stage the metrics where confusing to understand what was happening. Instead | |
| we split the single stage up into multiple smaller parts so the metrics are clearer. | |
| plan often has more metrics than the CPU versions do, and when we tried to combine all of these | |
| operations into a single stage the metrics were confusing to understand. Instead we split the single | |
| stage into multiple smaller parts so the metrics are clearer. |
docs/FAQ.md
Outdated
| entire stage in the plan. Code generation is typically used to reduce the cost of processing data | ||
| one row at a time. The GPU plan processes the data in a columnar format, so the costs are different. | ||
|
|
||
| * ColumnarToRow and RowToColumnar Transitions - The CPU version of Spark plans typically process data in a row based format. The main exception to |
There was a problem hiding this comment.
Should ColumnarToRow and RowToColumnar be backquoted, like, for example, WholeStageCodeGen is in the previous section?
Suggested change
| * ColumnarToRow and RowToColumnar Transitions - The CPU version of Spark plans typically process data in a row based format. The main exception to | |
| * `ColumnarToRow` and `RowToColumnar` transitions - The CPU version of Spark plans typically process data in a row based format. The main exception to |
|
I addressed the review comments and updated the metrics a bit. I was seeing much linger times than I expected for |
|
build |
jlowe
approved these changes
Jan 26, 2021
|
build |
|
@sameerz please take another look |
sameerz
approved these changes
Jan 27, 2021
gerashegalov
pushed a commit
to gerashegalov/spark-rapids
that referenced
this pull request
Jan 29, 2021
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1575 and fixes #103
I did not test topN with nested types going along for the ride (not being sorted on, but in the table that is being sorted), so I didn't turn them on. They should work, but it was not a requirement.
My initial performance tests showed a little bit of a performance gain over not supporting take ordered and project, but it was not a huge amount of data so it is hard to tell.