-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for running multiple queries in BenchmarkRunner #1591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andy Grove <andygrove@nvidia.com>
nit: copyright needs to be updated. Rest LGTM. |
Signed-off-by: Andy Grove <andygrove@nvidia.com>
build |
nartal1
approved these changes
Jan 26, 2021
Test failure is unrelated:
|
build |
build |
gerashegalov
approved these changes
Jan 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
build |
Failed with this again:
|
The failure is a known issue #1585 and a fix is being worked on for cudf |
build |
gerashegalov
pushed a commit
to gerashegalov/spark-rapids
that referenced
this pull request
Jan 29, 2021
tgravescs
pushed a commit
to tgravescs/spark-rapids
that referenced
this pull request
Nov 30, 2023
…IA#1591) Signed-off-by: Mike Wilson <knobby@burntsheep.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andy Grove andygrove@nvidia.com
When running against Kubernetes, it would be convenient to be able to run multiple queries from the Spark driver to avoid the overhead of cluster setup/teardown per query.
This PR modifies the spark-submit usage of BenchmarkRunner to change the query argument from a single value to a list of queries to run. The output logging is modified to include the query number so that automation can parse the output and capture timing information for each query.
There is no change to usage when used from Spark shell.