Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit length of spark app name in BenchmarkRunner #1610

Merged
merged 1 commit into from
Jan 28, 2021

Conversation

andygrove
Copy link
Contributor

Only include query name in spark app name when a single query is being run.

I needed this to resolve an issue when running automated benchmarks in Kubernetes, where the long app name exceeded the allowed length for pod names.

…g run

Signed-off-by: Andy Grove <andygrove@nvidia.com>
@andygrove andygrove added the benchmark Benchmarking, benchmarking tools label Jan 27, 2021
@andygrove andygrove added this to the Jan 18 - Jan 29 milestone Jan 27, 2021
@andygrove andygrove self-assigned this Jan 27, 2021
@andygrove
Copy link
Contributor Author

build

@andygrove andygrove merged commit 630698d into NVIDIA:branch-0.4 Jan 28, 2021
gerashegalov pushed a commit to gerashegalov/spark-rapids that referenced this pull request Jan 29, 2021
…g run (NVIDIA#1610)

Signed-off-by: Andy Grove <andygrove@nvidia.com>
@andygrove andygrove deleted the fix-app-name-length branch February 11, 2021 22:16
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
…g run (NVIDIA#1610)

Signed-off-by: Andy Grove <andygrove@nvidia.com>
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
…g run (NVIDIA#1610)

Signed-off-by: Andy Grove <andygrove@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark Benchmarking, benchmarking tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants