-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update explain format to show what will and will not run on the GPU #1624
Conversation
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, but should the user docs be updated to explain the meaning of the new symbols that are being added in the explain logging?
I am happy to do it, but I am not sure where to do it. Like I said there is no documentation right now explaining the format. I could update it in configs.md, but I am not sure that is the best place. The only other place it is mentioned is in tuning-guide.md |
I would think putting something in FAQ section and then also in the Monitoring section of the getting started on prep guide would be useful. but having an explanation be in its own section somewhere and link to it from those places makes sense to me. Or maybe we need to make the monitoring section its own. |
+1 for this. I think minimally the FAQ should have an entry for, "How do I tell if my query is running on the GPU?" which arguably is our most asked question. The FAQ also does mention |
I added docs to the FAQ. |
build |
…VIDIA#1624) Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
…VIDIA#1624) Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
This fixes #906
Plans now look something like
and
Now
*
indicates things that will run on the GPU@
indicates things that could run on the GPU but will not because the Exec they are a part of will not run on the GPU#
indicates things that have been removed from the plan for some reason!
indicates things that cannot run on the GPUThere is no real documentation for this format so I didn't update it. If this is something that we want to add I am happy to do it.