Explicitly add maven-jar-plugin version to improve incremental build time. #1631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgravescs
requested review from
GaryShen2008,
jlowe,
NvTimLiu and
revans2
as code owners
|
build |
revans2
approved these changes
Jan 29, 2021
jlowe
approved these changes
Jan 29, 2021
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
…time. (NVIDIA#1631) * specify the maven jar plugin version to speed up builds * fix spacing * use 3.2.0 version * signoff Signed-off-by: Thomas Graves <tgraves@nvidia.com>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
…time. (NVIDIA#1631) * specify the maven jar plugin version to speed up builds * fix spacing * use 3.2.0 version * signoff Signed-off-by: Thomas Graves <tgraves@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build time with scala maven plugin has gotten much worse after upgrading to 4.x. Adding in the specific version of maven-jar-plugin help this time. ie build when no code changes and skip tests takes 2 minutes on my desktop right now. With this change it takes 1 min 20 seconds.