Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move building from source docs to contributing guide #1649

Merged
merged 1 commit into from
Feb 2, 2021

Conversation

jlowe
Copy link
Member

@jlowe jlowe commented Feb 2, 2021

Fixes #1647

This collects the branching conventions and build instructions to the contributing guide and explains where to find the plugin jar after a successful build.

Signed-off-by: Jason Lowe <jlowe@nvidia.com>
@jlowe jlowe added the documentation Improvements or additions to documentation label Feb 2, 2021
@jlowe jlowe added this to the Feb 1 - Feb 12 milestone Feb 2, 2021
@jlowe jlowe self-assigned this Feb 2, 2021
@jlowe
Copy link
Member Author

jlowe commented Feb 2, 2021

build

@sameerz
Copy link
Collaborator

sameerz commented Feb 2, 2021

I will follow up on this by updating the https://nvidia.github.io/spark-rapids/docs/dev/testing.html section of our doc to be building and testing and point to the contributing guide.

Copy link
Collaborator

@gerashegalov gerashegalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlowe jlowe merged commit 5b6d228 into NVIDIA:branch-0.4 Feb 2, 2021
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
@jlowe jlowe deleted the build-docs branch September 10, 2021 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC]Build instructions for Rapids plugin
4 participants