Filter nulls for left semi and left anti join to work around cudf #1664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
performance issues Signed-off-by: Alessandro Bellina <abellina@nvidia.com>
jlowe
requested changes
Feb 3, 2021
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/execution/GpuHashJoin.scala
Show resolved
Hide resolved
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/execution/GpuHashJoin.scala
Show resolved
Hide resolved
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/execution/GpuHashJoin.scala
Show resolved
Hide resolved
jlowe
reviewed
Feb 3, 2021
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/execution/GpuHashJoin.scala
Show resolved
Hide resolved
jlowe
approved these changes
Feb 3, 2021
|
build |
revans2
approved these changes
Feb 4, 2021
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
…IDIA#1664) Signed-off-by: Alessandro Bellina <abellina@nvidia.com>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
…IDIA#1664) Signed-off-by: Alessandro Bellina <abellina@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
performance issues
Signed-off-by: Alessandro Bellina abellina@nvidia.com
Closes #1643
This is only targetting
leftSemiandleftAntibecause these are based oncudf::left_semi_anti_join, and this path was not sped up in 0.18 (specifically building the hash table for the join is slow with many nulls).This passes the tests locally, and I fixed some leaks I had but I need to run performance tests at scale, so I am posting it as draft for now.