Removed StructTypes support for ParquetCachedBatchSerializer as cudf doesn't support it yet #1723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
razajafri
changed the title
jlowe
reviewed
Feb 12, 2021
shims/spark311/src/main/scala/com/nvidia/spark/rapids/shims/spark311/Spark311Shims.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
|
build |
jlowe
approved these changes
Feb 13, 2021
sameerz
added
the
task
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
…doesn't support it yet (NVIDIA#1723) * Removed whitelisting of StructTypes as cudf doesn't support it Signed-off-by: Raza Jafri <rjafri@nvidia.com> * removed nested keyword Signed-off-by: Raza Jafri <rjafri@nvidia.com> Co-authored-by: Raza Jafri <rjafri@nvidia.com>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
…doesn't support it yet (NVIDIA#1723) * Removed whitelisting of StructTypes as cudf doesn't support it Signed-off-by: Raza Jafri <rjafri@nvidia.com> * removed nested keyword Signed-off-by: Raza Jafri <rjafri@nvidia.com> Co-authored-by: Raza Jafri <rjafri@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I whitelisted StructTypes thinking they are supported or very close to being supported in cudf. This won't be possible until rapidsai/7230 is merged
Signed-off-by: Raza Jafri rjafri@nvidia.com