Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setting local mode for tests #173

Merged
merged 1 commit into from
Jun 15, 2020
Merged

Fix setting local mode for tests #173

merged 1 commit into from
Jun 15, 2020

Conversation

revans2
Copy link
Collaborator

@revans2 revans2 commented Jun 15, 2020

One test was setting local sort incorrectly. Because of the large number of partitions is cause the GPU to do a lot of busy work to do the sorting when sorting locally was much faster.

@revans2 revans2 requested a review from firestarman June 15, 2020 14:47
@revans2
Copy link
Collaborator Author

revans2 commented Jun 15, 2020

build

@revans2 revans2 merged commit 8aac414 into NVIDIA:branch-0.1 Jun 15, 2020
@revans2 revans2 deleted the fix-test-local-sort branch June 15, 2020 15:19
@sameerz sameerz added this to the Jun 8 - Jun 19 milestone Jun 16, 2020
@sameerz sameerz added the test Only impacts tests label Jun 16, 2020
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Only impacts tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants