Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce regex use in CAST #1741

Merged
merged 12 commits into from
Feb 18, 2021
Merged

Reduce regex use in CAST #1741

merged 12 commits into from
Feb 18, 2021

Conversation

andygrove
Copy link
Contributor

@andygrove andygrove commented Feb 16, 2021 •
edited
Loading

This replaces four uses of regex in CAST with checks for expected length instead.

@andygrove
CAST string to temporal types now uses isTimestamp to detect valid in…
cb48046 
…puts

Signed-off-by: Andy Grove <andygrove@nvidia.com>
@andygrove
Bug fix in timestamp formats
53c917b
@andygrove
Update copyright and add additional test cases
0f3520f 
Signed-off-by: Andy Grove <andygrove@nvidia.com>
@andygrove
Refactor to avoid additional regex call
48e1c9c 
Signed-off-by: Andy Grove <andygrove@nvidia.com>
@andygrove
Remove regex for full timestamp match
2b0d86c 
Signed-off-by: Andy Grove <andygrove@nvidia.com>
@andygrove
Update comment
7316576
@andygrove
Add test data to demonstrate why regex was needed
9ab1292 
Signed-off-by: Andy Grove <andygrove@nvidia.com>
@andygrove
Reinstate regex for full timestamp
d5e0055 
Signed-off-by: Andy Grove <andygrove@nvidia.com>
@andygrove
Remove fixed-length date/timestamp regex checks
db34d8d 
Signed-off-by: Andy Grove <andygrove@nvidia.com>
@andygrove andygrove self-assigned this Feb 16, 2021
@andygrove andygrove added the performance A performance related task/issue label Feb 16, 2021
@andygrove andygrove added this to the Feb 16 - Feb 26 milestone Feb 16, 2021
@andygrove andygrove changed the base branch from branch-0.5 to branch-0.4 February 16, 2021 23:57
@andygrove andygrove linked an issue Feb 17, 2021 that may be closed by this pull request
[FEA] Reduce regex usage in CAST string to date/timestamp #1738
Closed
@andygrove andygrove changed the title WIP: Reduce regex use in CAST Reduce regex use in CAST Feb 17, 2021
@andygrove andygrove marked this pull request as ready for review February 17, 2021 18:27
@andygrove
Address PR feedback
acedeac 
Signed-off-by: Andy Grove <andygrove@nvidia.com>
@andygrove
Copy link
Contributor Author

build

@andygrove andygrove merged commit 17289c8 into NVIDIA:branch-0.4 Feb 18, 2021
@andygrove andygrove deleted the optimize-cast-regex-use branch February 18, 2021 20:10
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
@andygrove
Reduce regex use in CAST (NVIDIA#1741)
9897632
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
@andygrove
Reduce regex use in CAST (NVIDIA#1741)
d994a98
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlowe jlowe jlowe approved these changes

Assignees

@andygrove andygrove

Labels
performance A performance related task/issue
Projects
None yet
Milestone
Feb 16 - Feb 26
Development

Successfully merging this pull request may close these issues.

[FEA] Reduce regex usage in CAST string to date/timestamp
2 participants
@andygrove @jlowe