Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resource leaks in unit tests #1747

Merged
merged 2 commits into from
Feb 17, 2021
Merged

Fix resource leaks in unit tests #1747

merged 2 commits into from
Feb 17, 2021

Conversation

jlowe
Copy link
Member

@jlowe jlowe commented Feb 17, 2021

This fixes a number of device buffer leaks I noticed in the unit tests.

@jlowe jlowe added the test Only impacts tests label Feb 17, 2021
@jlowe jlowe added this to the Feb 16 - Feb 26 milestone Feb 17, 2021
@jlowe jlowe self-assigned this Feb 17, 2021
@jlowe
Copy link
Member Author

jlowe commented Feb 17, 2021

build

@jlowe jlowe changed the title Fix leaks Fix resource leaks in unit tests Feb 17, 2021
Copy link
Collaborator

@gerashegalov gerashegalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 🚢

@jlowe jlowe merged commit 659b31c into NVIDIA:branch-0.4 Feb 17, 2021
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
* Fix resource leaks in store suites

Signed-off-by: Jason Lowe <jlowe@nvidia.com>

* Fix compressed buffer leak in GpuCoalesceBatchesSuite
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
* Fix resource leaks in store suites

Signed-off-by: Jason Lowe <jlowe@nvidia.com>

* Fix compressed buffer leak in GpuCoalesceBatchesSuite
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Only impacts tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants