Fixed leaks in unit test and use ColumnarBatch for testing #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
build |
revans2
reviewed
Jun 16, 2020
revans2
reviewed
Jun 17, 2020
| try { | ||
| withResource(evaluateWithoutCodegen(gpuExpression, inputBatch)) { actual => | ||
|
|
||
| if (!checkResult(actual, expected, gpuExpression)) { |
There was a problem hiding this comment.
Sorry one more nit I just noticed. checkResult never returns false. It either throws or returns true. So we should remove the return from it and delete the dead code here
There was a problem hiding this comment.
Sorry, I didn't see the dead code.
I have addressed that concern, PTAL
|
build |
revans2
approved these changes
Jun 19, 2020
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
Co-authored-by: Raza Jafri <rjafri@nvidia.com>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
Co-authored-by: Raza Jafri <rjafri@nvidia.com>
tgravescs
pushed a commit
to tgravescs/spark-rapids
that referenced
this pull request
Nov 30, 2023
Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes leaks in the GpuUnitTests and also fixes the unit-testing approach to use ColumnarBatch instead of wrongly using the GpuLiteral to pass a vector
Fixes #168