check if modified files after update_config/supported #1809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peixin Li <pxli@nyu.edu>
pxLi
added
feature request
pxLi
requested review from
GaryShen2008,
jlowe,
NvTimLiu,
revans2 and
tgravescs
as code owners
|
build |
1 similar comment
|
build |
pxLi
force-pushed
the
check-if-modified-files
branch
from
432cedf
to
4e8ffa9
Compare
|
build |
pxLi
commented
Feb 25, 2021
| @@ -298,7 +298,7 @@ object RapidsConf { | |||
|
|
|||
| // Resource Configuration | |||
|
|
|||
| val PINNED_POOL_SIZE = conf("spark.rapids.memory.pinnedPool.size") | |||
| val PINNED_POOL_SIZE = conf("spark.rapids.memory.pinnedPool.size-DUMMY_MODIFIED") | |||
There was a problem hiding this comment.
e.g. the first commit failed (change to RpiadConf only but not config.md) as expected build 1023
|
CI Passed after remove the DUMMY change |
jlowe
approved these changes
Feb 25, 2021
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* check if modified files after update_config/supported Signed-off-by: Peixin Li <pxli@nyu.edu> * remove dummy config modified * fix success case
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* check if modified files after update_config/supported Signed-off-by: Peixin Li <pxli@nyu.edu> * remove dummy config modified * fix success case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Peixin Li pxli@nyu.edu
fix #661
validated working inside this PR w/ different commits