Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove INCOMPAT for NormalizeNanAndZero, KnownFloatingPointNormalized #181

Merged
merged 7 commits into from
Jun 18, 2020
Merged

Remove INCOMPAT for NormalizeNanAndZero, KnownFloatingPointNormalized #181

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9e3705c
Remove INCOMPAT for NormalizeNanAndZero, KnownFloatingPointNormalized
mythrocks Jun 15, 2020
11bd233
Remove INCOMPAT for NormalizeNanAndZero, KnownFloatingPointNormalized
mythrocks Jun 16, 2020
0874681
Merge remote-tracking branch 'origin/branch-0.1' into normalize-nans-…
mythrocks Jun 16, 2020
0226599
Merge remote-tracking branch 'origin/branch-0.1' into normalize-nans-…
mythrocks Jun 16, 2020
0a241a8
Remove INCOMPAT for NormalizeNanAndZero, KnownFloatingPointNormalized
mythrocks Jun 16, 2020
f427e5f
Remove INCOMPAT for NormalizeNanAndZero, KnownFloatingPointNormalized
mythrocks Jun 16, 2020
b0c38d6
Merge remote-tracking branch 'origin/branch-0.1' into normalize-nans-…
mythrocks Jun 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions sql-plugin/src/main/scala/ai/rapids/spark/GpuOverrides.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -867,15 +867,13 @@ object GpuOverrides {
(a, conf, p, r) => new UnaryExprMeta[NormalizeNaNAndZero](a, conf, p, r) {
override def convertToGpu(child: GpuExpression): GpuExpression =
GpuNormalizeNaNAndZero(child)
})
.incompat(FLOAT_DIFFERS_GROUP_INCOMPAT),
}),
expr[KnownFloatingPointNormalized](
"tag to prevent redundant normalization",
(a, conf, p, r) => new UnaryExprMeta[KnownFloatingPointNormalized](a, conf, p, r) {
override def convertToGpu(child: GpuExpression): GpuExpression =
GpuKnownFloatingPointNormalized(child)
})
.incompat(FLOAT_DIFFERS_GROUP_INCOMPAT),
}),
expr[DateDiff]("datediff", (a, conf, p, r) =>
new BinaryExprMeta[DateDiff](a, conf, p, r) {
override def convertToGpu(lhs: GpuExpression, rhs: GpuExpression): GpuExpression = {
Expand Down
6 changes: 2 additions & 4 deletions tests/src/test/scala/ai/rapids/spark/HashAggregatesSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1691,8 +1691,7 @@ class HashAggregatesSuite extends SparkQueryCompareTestSuite {
floatWithDifferentKindsOfNansAndZeros,
conf = new SparkConf()
.set(RapidsConf.HAS_NANS.key, "false")
.set(RapidsConf.ENABLE_FLOAT_AGG.key, "true")
.set(RapidsConf.INCOMPATIBLE_OPS.key, "true")) {
.set(RapidsConf.ENABLE_FLOAT_AGG.key, "true")) {
frame => frame.groupBy(col("float")).agg(sum(col("int")))
}

Expand All @@ -1701,8 +1700,7 @@ class HashAggregatesSuite extends SparkQueryCompareTestSuite {
doubleWithDifferentKindsOfNansAndZeros,
conf = new SparkConf()
.set(RapidsConf.HAS_NANS.key, "false")
.set(RapidsConf.ENABLE_FLOAT_AGG.key, "true")
.set(RapidsConf.INCOMPATIBLE_OPS.key, "true")) {
.set(RapidsConf.ENABLE_FLOAT_AGG.key, "true")) {
frame => frame.groupBy(col("double")).agg(sum(col("int")))
}
}