Expose row count statistics in GpuShuffleExchangeExec #1855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andy Grove <andygrove@nvidia.com>
jlowe
reviewed
Mar 3, 2021
shims/spark301/src/main/scala/com/nvidia/spark/rapids/shims/spark301/Spark301Shims.scala
Outdated
Show resolved
Hide resolved
…ark301/Spark301Shims.scala Co-authored-by: Jason Lowe <jlowe@nvidia.com>
…Exec instead of SparkPlan Signed-off-by: Andy Grove <andygrove@nvidia.com>
gerashegalov
previously approved these changes
Mar 3, 2021
| val shuffleExchanges = ShimLoader.getSparkShims | ||
| .findOperators(innerAdaptivePlan, _.isInstanceOf[ShuffleQueryStageExec]) | ||
| .map(_.asInstanceOf[ShuffleQueryStageExec]) | ||
| assert(shuffleExchanges.nonEmpty) |
There was a problem hiding this comment.
nit: maybe add a message to the assert for a more descriptive exception
There was a problem hiding this comment.
We haven't generally been using assertion messages. I have updated the assertion to make it more specific though.
| @@ -134,6 +135,10 @@ class Spark300Shims extends SparkShims { | |||
| override def isShuffleExchangeLike(plan: SparkPlan): Boolean = | |||
| plan.isInstanceOf[ShuffleExchangeExec] | |||
|
|
|||
| override def getQueryStageRuntimeStatistics(plan: QueryStageExec): Statistics = { | |||
| Statistics(0, None) | |||
There was a problem hiding this comment.
nit: Statistics(0) since None is the default for rowcount
sameerz
added
the
task
Signed-off-by: Andy Grove <andygrove@nvidia.com>
|
build |
abellina
previously approved these changes
Mar 4, 2021
jlowe
previously approved these changes
Mar 4, 2021
|
The new unit test failed against 3.1.x. I am investigating this. |
Signed-off-by: Andy Grove <andygrove@nvidia.com>
|
build |
|
Sorry, @abellina @gerashegalov @jlowe I had to push yet another change. CI is green now. Thanks. |
jlowe
requested changes
Mar 4, 2021
.../spark311/src/main/scala/com/nvidia/spark/rapids/shims/spark311/GpuShuffleExchangeExec.scala
Show resolved
Hide resolved
gerashegalov
reviewed
Mar 4, 2021
| val shuffleExchanges = ShimLoader.getSparkShims | ||
| .findOperators(innerAdaptivePlan, _.isInstanceOf[ShuffleQueryStageExec]) | ||
| .map(_.asInstanceOf[ShuffleQueryStageExec]) | ||
| assert(shuffleExchanges.length == 2) |
There was a problem hiding this comment.
nit: triple equals produces better diagnostics:
scala> assert(1 == 0)
org.scalatest.exceptions.TestFailedException
at org.scalatest.Assertions.newAssertionFailedException(Assertions.scala:528)
at org.scalatest.Assertions.newAssertionFailedException$(Assertions.scala:527)
at org.scalatest.Assertions$.newAssertionFailedException(Assertions.scala:1387)
at org.scalatest.Assertions$AssertionsHelper.macroAssert(Assertions.scala:501)
... 59 elided
scala> assert(1 === 0)
org.scalatest.exceptions.TestFailedException: 1 did not equal 0
at org.scalatest.Assertions.newAssertionFailedException(Assertions.scala:528)
at org.scalatest.Assertions.newAssertionFailedException$(Assertions.scala:527)
at org.scalatest.Assertions$.newAssertionFailedException(Assertions.scala:1387)
at org.scalatest.Assertions$AssertionsHelper.macroAssert(Assertions.scala:501)
... 59 elided
Signed-off-by: Andy Grove <andygrove@nvidia.com>
jlowe
previously approved these changes
Mar 4, 2021
|
build |
gerashegalov
previously approved these changes
Mar 4, 2021
Signed-off-by: Andy Grove <andygrove@nvidia.com>
|
build |
jlowe
approved these changes
Mar 5, 2021
abellina
approved these changes
Mar 5, 2021
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose row count statistics in GpuShuffleExchangeExec so that we can later use them as an input to the cost model