spillable cache for GpuCartesianRDD #1878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sperlingxx <lovedreamf@gmail.com>
|
build |
jlowe
requested changes
Mar 5, 2021
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/GpuCartesianProductExec.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/GpuCartesianProductExec.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/GpuCartesianProductExec.scala
Show resolved
Hide resolved
|
build |
jlowe
reviewed
Mar 8, 2021
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/GpuCartesianProductExec.scala
Show resolved
Hide resolved
Signed-off-by: sperlingxx <lovedreamf@gmail.com>
|
build |
jlowe
reviewed
Mar 12, 2021
| // happen if there exists specific plans like `LimitExec`. | ||
| context.addTaskCompletionListener[Unit]((_: TaskContext) => { | ||
| spillBatchBuffer.safeClose() | ||
| if (buildTableOnFlight.isDefined) buildTableOnFlight.get.close() |
There was a problem hiding this comment.
Suggested change
| if (buildTableOnFlight.isDefined) buildTableOnFlight.get.close() | |
| buildTableOnFlight.foreach(_.close()) |
There was a problem hiding this comment.
Change applied, Thx!
|
build |
1 similar comment
|
build |
jlowe
approved these changes
Mar 15, 2021
|
build |
revans2
approved these changes
Mar 16, 2021
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
Signed-off-by: sperlingxx <lovedreamf@gmail.com>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
Signed-off-by: sperlingxx <lovedreamf@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use SpillableColumnarBatch to cache stream-side data in case of re-computation caused by nested-loop. Current PR is the substitution of #1784, which based on
branch-0.4.Signed-off-by: sperlingxx lovedreamf@gmail.com