FileSourceScanExec can have logicalRelation parameter on some distributions #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
build |
jlowe
reviewed
Jun 16, 2020
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/GpuFileSourceScanExec.scala
Outdated
Show resolved
Hide resolved
…ourceScanExec.scala Co-authored-by: Jason Lowe <jlowe@nvidia.com>
jlowe
approved these changes
Jun 16, 2020
|
build |
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
…utions (NVIDIA#190) * FileSourceScanExec can have logicalRelation parameter on some distributions * Update sql-plugin/src/main/scala/org/apache/spark/sql/rapids/GpuFileSourceScanExec.scala Co-authored-by: Jason Lowe <jlowe@nvidia.com> Co-authored-by: Thomas Graves <tgraves@nvidia.com> Co-authored-by: Jason Lowe <jlowe@nvidia.com>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
…utions (NVIDIA#190) * FileSourceScanExec can have logicalRelation parameter on some distributions * Update sql-plugin/src/main/scala/org/apache/spark/sql/rapids/GpuFileSourceScanExec.scala Co-authored-by: Jason Lowe <jlowe@nvidia.com> Co-authored-by: Thomas Graves <tgraves@nvidia.com> Co-authored-by: Jason Lowe <jlowe@nvidia.com>
tgravescs
pushed a commit
to tgravescs/spark-rapids
that referenced
this pull request
Nov 30, 2023
Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handles some distributions of Spark having an extra LogicalRelation parameter for FileSourceScanExec. We aren't sure what this is used for but all of our testing so far, this has worked. We use reflection to determine the number of parameters it takes.
Tested with unit tests and integration tests and manually.