Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change cuDF dependency to 0.18.1 #1927

Merged
merged 2 commits into from
Mar 16, 2021
Merged

Conversation

NvTimLiu
Copy link
Collaborator

Change spark-rapids cuDF version dependency to 0.18.1

cuDF native updates version to v0.18.1 to fix the null-bounds issue: rapidsai/cudf#7568, we will need:

  1. release v0.18.1 java cuDF jars
  2. change spark-rapids jars cuDF dencpendency to 0.18.1

Signed-off-by: Tim Liu <timl@nvidia.com>
@NvTimLiu NvTimLiu added the build Related to CI / CD or cleanly building label Mar 12, 2021
@NvTimLiu NvTimLiu changed the base branch from branch-0.5 to branch-0.4 March 12, 2021 03:12
@NvTimLiu
Copy link
Collaborator Author

NvTimLiu commented Mar 12, 2021

Depend on the issue rapidsai/cudf#7568 and cuDF v0.18.1 native and Jars release

@@ -916,7 +916,7 @@ object RapidsConf {
|On startup use: `--conf [conf key]=[conf value]`. For example:
|
|```
|${SPARK_HOME}/bin/spark --jars 'rapids-4-spark_2.12-0.4.0.jar,cudf-0.18-cuda10-1.jar' \
|${SPARK_HOME}/bin/spark --jars 'rapids-4-spark_2.12-0.4.0.jar,cudf-0.18.1-cuda10-1.jar' \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change will make the configs.md changed after mvn verify, I think.
It'll cause the premerge failure since Peixin enabled the check of any changes after 'mvn verify'.
Do we really need to update it in this PR?

Copy link
Collaborator Author

@NvTimLiu NvTimLiu Mar 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, let me check it

The PR changes configs.md, will update it in another PR along with the docs

Copy link
Member

@jlowe jlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to update occurrences of cudf-0.18 in the documentation as well

@jlowe jlowe changed the title [WIP] Change cuDF dependency to 0.18.1 Change cuDF dependency to 0.18.1 Mar 12, 2021
@jlowe jlowe marked this pull request as draft March 12, 2021 14:19
Copy link
Member

@jlowe jlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The doc changes are being handled in #1934.

@pxLi pxLi marked this pull request as ready for review March 16, 2021 03:27
@pxLi
Copy link
Collaborator

pxLi commented Mar 16, 2021

build

@pxLi
Copy link
Collaborator

pxLi commented Mar 16, 2021

going to force merge this one and will trigger build for #1910

@pxLi pxLi merged commit 525c38c into NVIDIA:branch-0.4 Mar 16, 2021
@NvTimLiu NvTimLiu self-assigned this Mar 16, 2021
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
* Change cudf dependency to 0.18.1

Signed-off-by: Tim Liu <timl@nvidia.com>

* Revert RapidsConf.scala, will update it in another PR along with the docs
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
* Change cudf dependency to 0.18.1

Signed-off-by: Tim Liu <timl@nvidia.com>

* Revert RapidsConf.scala, will update it in another PR along with the docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Related to CI / CD or cleanly building
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants