-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change cuDF dependency to 0.18.1 #1927
Conversation
Signed-off-by: Tim Liu <timl@nvidia.com>
Depend on the issue rapidsai/cudf#7568 and cuDF v0.18.1 native and Jars release |
@@ -916,7 +916,7 @@ object RapidsConf { | |||
|On startup use: `--conf [conf key]=[conf value]`. For example: | |||
| | |||
|``` | |||
|${SPARK_HOME}/bin/spark --jars 'rapids-4-spark_2.12-0.4.0.jar,cudf-0.18-cuda10-1.jar' \ | |||
|${SPARK_HOME}/bin/spark --jars 'rapids-4-spark_2.12-0.4.0.jar,cudf-0.18.1-cuda10-1.jar' \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change will make the configs.md changed after mvn verify, I think.
It'll cause the premerge failure since Peixin enabled the check of any changes after 'mvn verify'.
Do we really need to update it in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, let me check it
The PR changes configs.md, will update it in another PR along with the docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to update occurrences of cudf-0.18 in the documentation as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The doc changes are being handled in #1934.
build |
going to force merge this one and will trigger build for #1910 |
* Change cudf dependency to 0.18.1 Signed-off-by: Tim Liu <timl@nvidia.com> * Revert RapidsConf.scala, will update it in another PR along with the docs
* Change cudf dependency to 0.18.1 Signed-off-by: Tim Liu <timl@nvidia.com> * Revert RapidsConf.scala, will update it in another PR along with the docs
Change spark-rapids cuDF version dependency to 0.18.1
cuDF native updates version to v0.18.1 to fix the null-bounds issue: rapidsai/cudf#7568, we will need: