-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relax cudf version check for patch-level versions #1930
Conversation
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
build |
build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@pxLi can you look into the signoff check failure that also succeeded? 🤔 The successful run should have cleared the older error but somehow did not. |
build |
build |
1 similar comment
build |
I see it passed now, there could be some delay for the github action to updated the status |
build |
CI failed. should be waiting for #1889 |
It passed because I pushed a new merge commit which caused it to run again. |
yep, I checked the github status, there were 2 terrible incidents for github action recently, |
build |
* Relax cudf version check for patch-level versions Signed-off-by: Jason Lowe <jlowe@nvidia.com> * whitespace * cleanup and use NumberFormatException * Cleanup checking with Try and startsWith * Add tests for many patch levels
* Relax cudf version check for patch-level versions Signed-off-by: Jason Lowe <jlowe@nvidia.com> * whitespace * cleanup and use NumberFormatException * Cleanup checking with Try and startsWith * Add tests for many patch levels
Fixes #1921.
This updates the cudf version check to be lenient on patch-level differences. The patch level, and any sub-version afterwards, can be different as long as it is more recent (i.e.: greater) than the requested version.