Update Alias SQL quoting and float-to-timestamp casting to match Spark 3.2 #1935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k 3.2 Signed-off-by: Jason Lowe <jlowe@nvidia.com>
|
build |
|
I can see why we might want the cast to be configured by the shim, but honestly these are bug fixes, and I'm not really sure why we need to break older versions when we could fix it for them, especially the SQL alias code. |
revans2
approved these changes
Mar 15, 2021
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
…k 3.2 (NVIDIA#1935) Signed-off-by: Jason Lowe <jlowe@nvidia.com>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
…k 3.2 (NVIDIA#1935) Signed-off-by: Jason Lowe <jlowe@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alias SQL quoting behavior changed in SPARK-34626 and float-to-timestamp casting behavior changed in SPARK-34727 to upcast to double first.
This adds shim-specific flags to know when to apply these changed behaviors so the plugin remains compatible with the behavior with older versions of Spark while also matching the new Spark 3.2 behavior.