Branch 0.5 doc remove numpartitions #1951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sameer Raheja <sraheja@nvidia.com>
Signed-off-by: Sameer Raheja <sraheja@nvidia.com>
jlowe
reviewed
Mar 16, 2021
There was a problem hiding this comment.
Note that we also have a shuffle partition setting in the AWS EMR guide which should probably be removed as well.
Signed-off-by: Sameer Raheja <sraheja@nvidia.com>
|
Removed from AWS EMR getting started guide as well. |
jlowe
approved these changes
Mar 17, 2021
There was a problem hiding this comment.
This will need to be upmerged to branch-0.5 after #1889 is merged to get the premerge CI to pass. Not worth performing a premerge CI build until that happens. Assuming the merge of branch-0.5 goes in clean, this approval should "stick."
|
build |
|
This will likely need to upmerge with branch-0.5 to get premerge CI to pass. |
…nto branch-0.5-doc-remove-numpartitions
|
build |
1 similar comment
|
build |
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* Remove --conf spark.sql.shuffle.partitions=10 from docs Signed-off-by: Sameer Raheja <sraheja@nvidia.com> * Remove spark.sql.shuffle.partitions=40 from get-started/yarn-gpu.md Signed-off-by: Sameer Raheja <sraheja@nvidia.com> * Remove spark.sql.shuffle.partitions from AWS EMR getting started gui Signed-off-by: Sameer Raheja <sraheja@nvidia.com>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* Remove --conf spark.sql.shuffle.partitions=10 from docs Signed-off-by: Sameer Raheja <sraheja@nvidia.com> * Remove spark.sql.shuffle.partitions=40 from get-started/yarn-gpu.md Signed-off-by: Sameer Raheja <sraheja@nvidia.com> * Remove spark.sql.shuffle.partitions from AWS EMR getting started gui Signed-off-by: Sameer Raheja <sraheja@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1853
The
spark.sql.shuffle.partitionsdefault is 200, we should let uses modify if they need rather than put in a setting. We have information about tuning this in https://nvidia.github.io/spark-rapids/docs/tuning-guide.html .