support GpuSize #1972
Merged
support GpuSize #1972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sperlingxx <lovedreamf@gmail.com>
|
build |
revans2
reviewed
Mar 19, 2021
| expr[Size]( | ||
| "The size of an array or a map", | ||
| ExprChecks.unaryProjectNotLambda(TypeSig.INT, TypeSig.INT, | ||
| (TypeSig.ARRAY + TypeSig.MAP).nested(TypeSig.all), |
There was a problem hiding this comment.
We need to removed UDT from this for the non-spark use case. This is just to make the docs correct, because we don't support UDT anywhere.
| // In JNI layer, we add 1 to the child index when fetching child column of ListType to keep | ||
| // alignment. | ||
| // So, in JVM layer, we have to use -1 as index to fetch the real first child of list_column. | ||
| withResource(inputBase.getChildColumnView(-1)) { offset => |
There was a problem hiding this comment.
Lets just add in JNI for this instead.
It does everything we want, except for the legacy null behavior, and we can fix that up without too much work.
var ret = intput.getBase.countElements()
if (legacySizeOfNull) {
withResource(input.getBase.isNull()) { isNull =>
withResource(GpuScalar.from(-1)) { negOne =>
withResource(ret) { count =>
ret = isNull.ifElse(negOne, count)
}
}
}
}
revans2
approved these changes
Mar 19, 2021
|
I filed #1974 as a follow on issue for this. |
sameerz
added
the
task
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
Signed-off-by: sperlingxx <lovedreamf@gmail.com>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
Signed-off-by: sperlingxx <lovedreamf@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to support
GpuSize.The intention is to fix test failures on
GpuExplodeunder spark 3.1. The root cause of the failure is that in spark 3.1 newly added ruleInferFiltersFromGeneratewill insert a group by expressions include GPU unsupported expressionSize.Signed-off-by: sperlingxx lovedreamf@gmail.com