Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor logic for parallel testing #2016

Merged
merged 2 commits into from
Mar 26, 2021

Conversation

gerashegalov
Copy link
Collaborator

Reduce code duplication in run_pyspark_from_build.sh.

Borrowing logic tested in #1688

Tested with

# single threaded
TEST_PARALLEL=1 SPARK_HOME=~/spark-3.1.1-bin-hadoop3.2 integration_tests/run_pyspark_from_build.sh -k test_single_orderby

# parallel: 
TEST_PARALLEL=4 SPARK_HOME=~/spark-3.1.1-bin-hadoop3.2 integration_tests/run_pyspark_from_build.sh -k test_single_orderby

Signed-off-by: Gera Shegalov <gera@apache.org>
@gerashegalov gerashegalov added the test Only impacts tests label Mar 24, 2021
@gerashegalov
Copy link
Collaborator Author

build

@gerashegalov
Copy link
Collaborator Author

build

1 similar comment
@gerashegalov
Copy link
Collaborator Author

build

@pxLi
Copy link
Collaborator

pxLi commented Mar 26, 2021

I saw this already been triggered not sure why trigger twice for the same commit. If the previous one is not required plz help abort to save resource, thx~

rapids_premerge-github 1253
rapids_premerge-github 1254

@revans2 revans2 merged commit 09b2d32 into NVIDIA:branch-0.5 Mar 26, 2021
@gerashegalov
Copy link
Collaborator Author

@pxLi sorry, my browser UI probably did not refresh and I mistakenly thought my first build comment didn't go through. Now I see that I have duplicate build comments.

@gerashegalov gerashegalov deleted the refactor_run_pyspakr branch March 26, 2021 22:00
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
Signed-off-by: Gera Shegalov <gera@apache.org>
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
Signed-off-by: Gera Shegalov <gera@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Only impacts tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants