Improve error message after failed RMM shutdown #2080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andy Grove <andygrove@nvidia.com>
andygrove
changed the title
abellina
previously approved these changes
Apr 6, 2021
| case object Uninitialized extends MemoryState | ||
| case object Uninitializable extends MemoryState | ||
|
|
||
|
|
Signed-off-by: Andy Grove <andygrove@nvidia.com>
jlowe
reviewed
Apr 6, 2021
sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuDeviceManager.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuDeviceManager.scala
Outdated
Show resolved
Hide resolved
…ager.scala Co-authored-by: Jason Lowe <jlowe@nvidia.com>
…ager.scala Co-authored-by: Jason Lowe <jlowe@nvidia.com>
Signed-off-by: Andy Grove <andygrove@nvidia.com>
jlowe
approved these changes
Apr 6, 2021
abellina
approved these changes
Apr 6, 2021
|
build |
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* Improve error message after failed RMM shutdown Signed-off-by: Andy Grove <andygrove@nvidia.com> * Remove blank line Signed-off-by: Andy Grove <andygrove@nvidia.com> * Update sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuDeviceManager.scala Co-authored-by: Jason Lowe <jlowe@nvidia.com> * Update sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuDeviceManager.scala Co-authored-by: Jason Lowe <jlowe@nvidia.com> * Rename Uninitializable to Errored Signed-off-by: Andy Grove <andygrove@nvidia.com> Co-authored-by: Jason Lowe <jlowe@nvidia.com>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* Improve error message after failed RMM shutdown Signed-off-by: Andy Grove <andygrove@nvidia.com> * Remove blank line Signed-off-by: Andy Grove <andygrove@nvidia.com> * Update sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuDeviceManager.scala Co-authored-by: Jason Lowe <jlowe@nvidia.com> * Update sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuDeviceManager.scala Co-authored-by: Jason Lowe <jlowe@nvidia.com> * Rename Uninitializable to Errored Signed-off-by: Andy Grove <andygrove@nvidia.com> Co-authored-by: Jason Lowe <jlowe@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exceptions during
GpuDeviceManager.shutdowncan lead toGpuDeviceManagerandRapidsBufferCatalogbeing left in an inconsistent state which results inNullPointerExceptionwhen accessing uninitialized state.This PR changes the
singletonMemoryInitializedflag from a boolean to aMemoryStatedata type with possible values ofInitialized,Uninitialized, andUninitializable, with appropriate error checking added.Signed-off-by: Andy Grove andygrove@nvidia.com