Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dynamic Spark configuration for Databricks #2116
Add dynamic Spark configuration for Databricks #2116
Changes from 1 commit
244ef65
4631bb9
0367a2b
0331f3a
1353df7
48f136d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here add the single quotas '%s', because we need to escape the backspaces to make the confs string
--conf spark.xxx.xxx=xxx --conf spark.xxx.yyy=zzz ......
as one parameterOtherwise the config string will be parsed as several parameters asperated by the backspaces
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to translate
--conf spark.xxx=xxx
intoexport PYSP_TEST_spark_xxx=xxx
, as we are calling the scriptrun_pyspark_from_build.sh
to parallelly run the integration tests.The scripts
run_pyspark_from_build.sh
requires us to translate spark confs intoexport PYSP_TEST_spark_xxx=xxx
to run IT with parallelism.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
append the dynamic spark confs here