Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in Partition type check support #2128

Merged
merged 2 commits into from
Apr 15, 2021

Conversation

revans2
Copy link
Collaborator

@revans2 revans2 commented Apr 14, 2021

This fixes #1915

I could add in support for input/output checks for Parquet, Orc, and CSV if people want me to, but I thought I would keep it simple to start out with.

This also addresses part of #1755 by outputting headers periodically in the tables. It is better than it was before, but I don't think it is a final solution.

Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
@revans2 revans2 added the feature request New feature or request label Apr 14, 2021
@revans2 revans2 added this to the Apr 12 - Apr 23 milestone Apr 14, 2021
@revans2 revans2 self-assigned this Apr 14, 2021
@revans2
Copy link
Collaborator Author

revans2 commented Apr 14, 2021

build

jlowe
jlowe previously approved these changes Apr 14, 2021
Copy link
Member

@jlowe jlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a minor simplification suggestion, lgtm.

@revans2
Copy link
Collaborator Author

revans2 commented Apr 14, 2021

build

1 similar comment
@revans2
Copy link
Collaborator Author

revans2 commented Apr 15, 2021

build

@revans2 revans2 merged commit 690fc29 into NVIDIA:branch-0.5 Apr 15, 2021
@revans2 revans2 deleted the more_type_checks branch April 15, 2021 15:38
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] follow on work for hash partitioning changes
2 participants