Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix index-based access to the head elements #2192

Merged
merged 2 commits into from
Apr 21, 2021
Merged

Fix index-based access to the head elements #2192

merged 2 commits into from
Apr 21, 2021

Conversation

gerashegalov
Copy link
Collaborator

@gerashegalov gerashegalov commented Apr 20, 2021 •
edited
Loading

Signed-off-by: Gera Shegalov gera@apache.org

Fix simple collection operations. Contributes to #2109

  • replace map with foreach when the return value is not used
  • forall where appropriate
  • access head elements without specifying indices.
  • simplify index iteration

@gerashegalov
Fix index-base access to the head elements
8465fa3 
Signed-off-by: Gera Shegalov <gera@apache.org>
@gerashegalov
Copy link
Collaborator Author

build

1 similar comment
@pxLi
Copy link
Collaborator

pxLi commented Apr 20, 2021

build

@gerashegalov gerashegalov changed the title Fix index-base access to the head elements Fix index-based access to the head elements Apr 20, 2021
@sameerz sameerz added the task Work required that improves the product but is not user facing label Apr 20, 2021
@sameerz sameerz added this to the Apr 12 - Apr 23 milestone Apr 20, 2021
andygrove
andygrove approved these changes Apr 20, 2021
View reviewed changes
Copy link
Contributor

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup. LGTM.

@gerashegalov gerashegalov self-assigned this Apr 20, 2021
@gerashegalov
Copy link
Collaborator Author

build

@gerashegalov
Copy link
Collaborator Author

ran a shim spark301db build too

@gerashegalov gerashegalov merged commit 7e66f53 into NVIDIA:branch-0.5 Apr 21, 2021
@gerashegalov gerashegalov deleted the 2109_indices branch April 21, 2021 01:34
@jlowe jlowe mentioned this pull request Apr 21, 2021
Closed
This was referenced Apr 23, 2021
Merged
Closed
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
@gerashegalov
Fix index-based access to the head elements (NVIDIA#2192)
1b43da5 
Signed-off-by: Gera Shegalov <gera@apache.org>

Fix simple collection operations. Contributes to NVIDIA#2109 
- replace map with foreach when the return value is not used
- forall where appropriate
- access head elements without specifying indices.
- simplify index iteration
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
@gerashegalov
Fix index-based access to the head elements (NVIDIA#2192)
a027049 
Signed-off-by: Gera Shegalov <gera@apache.org>

Fix simple collection operations. Contributes to NVIDIA#2109 
- replace map with foreach when the return value is not used
- forall where appropriate
- access head elements without specifying indices.
- simplify index iteration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andygrove andygrove andygrove approved these changes

@jlowe jlowe jlowe approved these changes

@revans2 revans2 Awaiting requested review from revans2

@nartal1 nartal1 Awaiting requested review from nartal1

Assignees

@gerashegalov gerashegalov

Labels
task Work required that improves the product but is not user facing
Projects
None yet
Milestone
Apr 12 - Apr 23
Development

Successfully merging this pull request may close these issues.
5 participants
@gerashegalov @pxLi @andygrove @jlowe @sameerz