fix batch size default values in the tuning guide #2207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rongou
added
bug
jlowe
previously approved these changes
Apr 20, 2021
Signed-off-by: Rong Ou <rong.ou@gmail.com>
rongou
force-pushed
the
fix-tuning-guide-batch-sizes
branch
from
95c729e
to
ab58f4e
Compare
rongou
requested review from
GaryShen2008,
NvTimLiu,
revans2 and
tgravescs
as code owners
jlowe
approved these changes
Apr 20, 2021
|
build |
revans2
approved these changes
Apr 21, 2021
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
Signed-off-by: Rong Ou <rong.ou@gmail.com>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
Signed-off-by: Rong Ou <rong.ou@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rong Ou rong.ou@gmail.com
All these values default to
Integer.MAX_VALUE, which is2147483647, not2147483648.