-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add spark312 and spark320 versions of cache serializer #2264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Lowe <jlowe@nvidia.com>
jlowe
changed the title
Add spark312 and spar320 versions of cache serializer
Add spark312 and spark320 versions of cache serializer
Apr 26, 2021
build |
razajafri
previously approved these changes
Apr 26, 2021
Sorry, I forgot that I had reverted the change that added the files https://github.com/NVIDIA/spark-rapids/pull/2208/files. |
Can you also add the doc change? Or do you want me to add to this? |
razajafri
approved these changes
Apr 26, 2021
build |
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* Add spark312 and spark320 versions of cache serializer Signed-off-by: Jason Lowe <jlowe@nvidia.com> * Update serializer docs
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* Add spark312 and spark320 versions of cache serializer Signed-off-by: Jason Lowe <jlowe@nvidia.com> * Update serializer docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #2204 the nightly tests are failing with this error:
The scripts are asking for a shim-specific cache serializer but there's currently only the spark311 version. This adds spark312 and spark320 versions of the cache batch serializer which are trivial derivations of the spark311 version.