Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let default branch to master per the release rule #241

Merged
merged 1 commit into from
Jun 20, 2020
Merged

Let default branch to master per the release rule #241

merged 1 commit into from
Jun 20, 2020

Conversation

firestarman
Copy link
Collaborator

This PR is to change the default branch to master for the release Jenkins job.
No test is needed.
No issue is relevant.

@firestarman
Copy link
Collaborator Author

build

@jlowe
Copy link
Member

jlowe commented Jun 19, 2020

what's the plan for publishing snapshots?

@sameerz sameerz added the build Related to CI / CD or cleanly building label Jun 19, 2020
@sameerz sameerz added this to the Jun 8 - Jun 19 milestone Jun 19, 2020
jlowe
jlowe approved these changes Jun 19, 2020
View reviewed changes
Copy link
Member

@jlowe jlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a little weird to have a script on a particular branch not referring to that branch in the Jenkins build. We'll get this sorted out along with what's going on with snapshot releases after 0.1.0 is out.

@firestarman
Copy link
Collaborator Author

It's a little weird to have a script on a particular branch not referring to that branch in the Jenkins build. We'll get this sorted out along with what's going on with snapshot releases after 0.1.0 is out.

The release Jenkins job also uses this parameter to decide which branch should be fetched from remote per our job branch setting as below, supported by Jenkins.
${REF}
So this is the same branch being built and deployed by the following stages.

@firestarman
Copy link
Collaborator Author

firestarman commented Jun 20, 2020 •
edited
Loading

what's the plan for publishing snapshots?

Now how to publish snapshots is still under discussion, i think. Suppose this Jenkinsfile is used for pushlishing release version only.

@firestarman firestarman merged commit 7a1515c into NVIDIA:branch-0.1 Jun 20, 2020
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
@firestarman
Let default branch to master per the release rule (NVIDIA#241)
26c3bb5 
Co-authored-by: Liangcai Li <liangcail@nvidia.com>
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
@firestarman
Let default branch to master per the release rule (NVIDIA#241)
28704f5 
Co-authored-by: Liangcai Li <liangcail@nvidia.com>
tgravescs pushed a commit to tgravescs/spark-rapids that referenced this pull request Nov 30, 2023
@nvauto
Update submodule cudf to 1bb3aac (NVIDIA#241)
23fdf0c 
Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlowe jlowe jlowe approved these changes

@revans2 revans2 revans2 approved these changes

@GaryShen2008 GaryShen2008 Awaiting requested review from GaryShen2008

Assignees
No one assigned
Labels
build Related to CI / CD or cleanly building
Projects
None yet
Milestone
Jun 8 - Jun 19
Development

Successfully merging this pull request may close these issues.
4 participants
@firestarman @jlowe @revans2 @sameerz