Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix concat_ws test specifying only a separator for databricks #2533

Merged
merged 1 commit into from
May 28, 2021
Merged

Fix concat_ws test specifying only a separator for databricks #2533

merged 1 commit into from
May 28, 2021

Conversation

tgravescs
Copy link
Collaborator

@tgravescs tgravescs commented May 27, 2021 •
edited
Loading

The test specifies concat_ws with only a separator. Databricks is smart enough to optimize that out to be gpuisnotnull(c#1572787)) else null so the test fails to find concatWs on the cpu.

Simply xfail this test on databricks.

Signed-off-by: Thomas Graves tgraves@nvidia.com

@tgravescs
Fix concat_ws test for databricks
3b16390 
Signed-off-by: Thomas Graves <tgraves@nvidia.com>
@tgravescs tgravescs added the test Only impacts tests label May 27, 2021
@tgravescs tgravescs added this to the May 24 - Jun 4 milestone May 27, 2021
@tgravescs tgravescs self-assigned this May 27, 2021
@tgravescs
Copy link
Collaborator Author

build

@tgravescs
Copy link
Collaborator Author

the original failure was:

: java.lang.AssertionError: assertion failed: Could not find ConcatWs in the GPU plan[0m
15:34:56  [1m[31mE                   GpuColumnarToRow false[0m
15:34:56  [1m[31mE                   +- GpuProject [if (gpuisnotnull(c#1572787))  else null AS concat_ws(c)#1572794][0m
15:34:56  [1m[31mE                      +- GpuRowToColumnar TargetSize(2147483647)[0m
15:34:56  [1m[31mE                         +- *(1) Scan ExistingRDD[a#1572785,b#1572786,c#1572787][0m

@tgravescs tgravescs merged commit d90c836 into NVIDIA:branch-21.06 May 28, 2021
@tgravescs tgravescs deleted the dbconcatfix branch May 28, 2021 00:11
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
@tgravescs
Fix concat_ws test for databricks (NVIDIA#2533)
75b5e06 
Signed-off-by: Thomas Graves <tgraves@nvidia.com>
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
@tgravescs
Fix concat_ws test for databricks (NVIDIA#2533)
b257a3c 
Signed-off-by: Thomas Graves <tgraves@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@revans2 revans2 revans2 approved these changes

Assignees

@tgravescs tgravescs

Labels
test Only impacts tests
Projects
None yet
Milestone
May 24 - Jun 4
Development

Successfully merging this pull request may close these issues.
2 participants
@tgravescs @revans2