Implement test for qualification tool sql metric aggregates #2591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andy Grove <andygrove@nvidia.com>
Signed-off-by: Andy Grove <andygrove@nvidia.com>
Signed-off-by: Andy Grove <andygrove@nvidia.com>
Signed-off-by: Andy Grove <andygrove@nvidia.com>
Signed-off-by: Andy Grove <andygrove@nvidia.com>
Signed-off-by: Andy Grove <andygrove@nvidia.com>
Signed-off-by: Andy Grove <andygrove@nvidia.com>
andygrove
changed the title
Signed-off-by: Andy Grove <andygrove@nvidia.com>
tgravescs
reviewed
Jun 4, 2021
| @@ -97,4 +99,73 @@ class QualificationSuite extends FunSuite with Logging { | |||
| val logFiles = Array(s"$logDir/nds_q86_test") | |||
| runQualificationTest(logFiles, "nds_q86_test_expectation.csv") | |||
| } | |||
|
|
|||
| test("sql metric agg") { | |||
There was a problem hiding this comment.
we could do this separately and if you don't have time this week just let me know, but it would be nice to also validate the sql time aggregation across multiple SQL jobs. Add in one with dataset for bonus.
tgravescs
previously approved these changes
Jun 4, 2021
|
build |
tgravescs
reviewed
Jun 4, 2021
|
|
||
| def generateEventLog(eventLogDir: File, appName: String) | ||
| (fun: SparkSession => DataFrame): String = { | ||
| val spark = SparkSession |
nartal1
previously approved these changes
Jun 4, 2021
|
@andygrove Test seems to be failing. |
Signed-off-by: Andy Grove <andygrove@nvidia.com>
|
build |
tgravescs
previously approved these changes
Jun 4, 2021
nartal1
previously approved these changes
Jun 4, 2021
|
build |
nartal1
approved these changes
Jun 4, 2021
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
) * Fix package name Signed-off-by: Andy Grove <andygrove@nvidia.com> * Rename to ToolTestUtils Signed-off-by: Andy Grove <andygrove@nvidia.com> * Implement basic structure for test Signed-off-by: Andy Grove <andygrove@nvidia.com> * Test checks that number of tasks is correct Signed-off-by: Andy Grove <andygrove@nvidia.com> * Add more tests Signed-off-by: Andy Grove <andygrove@nvidia.com> * Add cpuTime test, commented out Signed-off-by: Andy Grove <andygrove@nvidia.com> * Change executorCpuTime logic to match qualification tool Signed-off-by: Andy Grove <andygrove@nvidia.com> * use dedicated spark session in test * create new SparkSession before each test Signed-off-by: Andy Grove <andygrove@nvidia.com>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
) * Fix package name Signed-off-by: Andy Grove <andygrove@nvidia.com> * Rename to ToolTestUtils Signed-off-by: Andy Grove <andygrove@nvidia.com> * Implement basic structure for test Signed-off-by: Andy Grove <andygrove@nvidia.com> * Test checks that number of tasks is correct Signed-off-by: Andy Grove <andygrove@nvidia.com> * Add more tests Signed-off-by: Andy Grove <andygrove@nvidia.com> * Add cpuTime test, commented out Signed-off-by: Andy Grove <andygrove@nvidia.com> * Change executorCpuTime logic to match qualification tool Signed-off-by: Andy Grove <andygrove@nvidia.com> * use dedicated spark session in test * create new SparkSession before each test Signed-off-by: Andy Grove <andygrove@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests to ensure that we are correctly aggregating SQL metrics in the qualification tool.