Change the README of the qualification and profiling tool to match the current version. #2594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the README of the qualification and profiling tool to match the current version.
viadea
requested review from
tgravescs,
razajafri,
sameerz,
nartal1,
andygrove and
gerashegalov
tgravescs
reviewed
Jun 4, 2021
rapids-4-spark-tools/README.md
Outdated
|
|
||
| The profiling tool generates information which can be used for ranking applications debugging and profiling. | ||
| Information such as Spark version, executor information, Properties and so on. Works with both cpu and gpu generated event logs. | ||
| Information such as Spark version, executor information, properties and so on. | ||
| Works with both CPU and GPU generated event logs. |
There was a problem hiding this comment.
qualification tool is really mean to be run on cpu logs.
There was a problem hiding this comment.
Yep this is for profiling tool part.
In the qualification part, we mentioned Works with CPU generated event logs.
Does it look good to you?
tgravescs
reviewed
Jun 4, 2021
Add definition for SQL dataframe duration
tgravescs
previously approved these changes
Jun 4, 2021
|
build |
tgravescs
approved these changes
Jun 5, 2021
|
build |
nartal1
approved these changes
Jun 5, 2021
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
…e current version. (NVIDIA#2594) * Signed-off-by: Hao Zhu <hazhu@nvidia.com> Change the README of the qualification and profiling tool to match the current version. * Update README.md * Add definition for SQL dataframe duration Add definition for SQL dataframe duration * Add notes for UDFs * Added sample text output for qualification. * Fix a typo * Added the new profiling functions in Analysis
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
…e current version. (NVIDIA#2594) * Signed-off-by: Hao Zhu <hazhu@nvidia.com> Change the README of the qualification and profiling tool to match the current version. * Update README.md * Add definition for SQL dataframe duration Add definition for SQL dataframe duration * Add notes for UDFs * Added sample text output for qualification. * Fix a typo * Added the new profiling functions in Analysis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the README of the qualification and profiling tool to match the current version.