-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Profiling tool: Print UCX and GDS parameters #2785
Merged
Merged
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
dd3eee6
print UCX parameters
nartal1 238f6c9
Merge branch 'branch-21.08' of github.com:NVIDIA/spark-rapids into gd…
nartal1 7168d38
Profiling tool: Print UCX and GDS parameters
nartal1 fb3867f
Merge branch 'branch-21.08' of github.com:NVIDIA/spark-rapids into gd…
nartal1 43766cc
Merge branch 'branch-21.08' of github.com:NVIDIA/spark-rapids into gd…
nartal1 52fb2f8
addressed review comments
nartal1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -322,4 +322,28 @@ class ApplicationInfoSuite extends FunSuite with Logging { | |
tempFile4.delete() | ||
} | ||
} | ||
|
||
test("test gds-ucx-parameters") { | ||
val apps: ArrayBuffer[ApplicationInfo] = ArrayBuffer[ApplicationInfo]() | ||
val appArgs = | ||
new ProfileArgs(Array(s"$logDir/gds_ucx_eventlog.zstd")) | ||
var index: Int = 1 | ||
val eventlogPaths = appArgs.eventlog() | ||
for (path <- eventlogPaths) { | ||
apps += new ApplicationInfo(appArgs.numOutputRows.getOrElse(1000), sparkSession, | ||
EventLogPathProcessor.getEventLogInfo(path, sparkSession).head._1, index) | ||
index += 1 | ||
} | ||
assert(apps.size == 1) | ||
for (app <- apps) { | ||
val rows = app.runQuery(query = app.generateRapidsUcxGdsProperties + " order by key", | ||
fileWriter = None).collect() | ||
assert(rows.length == 22) // 22 properties captured. | ||
// verify ucx parameters are captured. | ||
assert(rows(1)(0).equals("spark.executorEnv.UCX_MAX_RNDV_RAILS")) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is order guaranteed here? Would be better to kit reference specific rows There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. order is guaranteed here. using order by propertyName in the query. |
||
|
||
//verify gds parameters are captured. | ||
assert(rows(11)(0).equals("spark.rapids.memory.gpu.direct.storage.spill.useHostMemory")) | ||
} | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we use a more generic name here, such as
generateNvidiaProperties
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.