Clean up GpuCollectLimitMeta and add in metrics #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
build |
jlowe
requested changes
Jun 25, 2020
|
build |
jlowe
approved these changes
Jun 25, 2020
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* Clean up GpuCollectLimitMeta and add in metrics * Addressed review comments
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* Clean up GpuCollectLimitMeta and add in metrics * Addressed review comments
pxLi
pushed a commit
to pxLi/spark-rapids
that referenced
this pull request
May 12, 2022
* Change log levels for some logs in private * Fix issues * Undo remove
tgravescs
pushed a commit
to tgravescs/spark-rapids
that referenced
this pull request
Nov 30, 2023
Signed-off-by: spark-rapids automation <70000568+nvauto@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran across this while trying to figure out what to do about cross join. There were no metrics for limit so I added them in, and the code for
GpuCollectLimitExecwas not doing what we thought it was. It was limiting based off of the number of batches, not the number of rows, and with a small change to the meta we could remove all of that code.