Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated RunningWindow to support extended types too #3148

Merged
merged 1 commit into from
Aug 5, 2021
Merged

Updated RunningWindow to support extended types too #3148

merged 1 commit into from
Aug 5, 2021

Conversation

revans2
Copy link
Collaborator

@revans2 revans2 commented Aug 5, 2021

This fixes #3147

@revans2
Updated RunningWindow to support extended types too
3b4caa0 
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
@revans2 revans2 added the bug Something isn't working label Aug 5, 2021
@revans2 revans2 added this to the Aug 2 - Aug 13 milestone Aug 5, 2021
@revans2 revans2 self-assigned this Aug 5, 2021
@revans2
Copy link
Collaborator Author

revans2 commented Aug 5, 2021

build

jlowe
jlowe approved these changes Aug 5, 2021
View reviewed changes
Copy link
Member

@jlowe jlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks OK, but do we want a test with a map type to ensure we don't regress?

@jlowe
Copy link
Member

jlowe commented Aug 5, 2021

do we want a test with a map type to ensure we don't regress?

Ah, missed that the tests already exist and this is a fix for those tests.

@revans2 revans2 merged commit d1327f8 into NVIDIA:branch-21.10 Aug 5, 2021
@revans2 revans2 deleted the window_db_expand_fix branch August 5, 2021 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlowe jlowe jlowe approved these changes

Assignees

@revans2 revans2

Labels
bug Something isn't working
Projects
None yet
Milestone
Aug 2 - Aug 13
Development

Successfully merging this pull request may close these issues.

[BUG] window_function_test.py::test_window_ride_along failed in databricks runtime
2 participants
@revans2 @jlowe